Petko Manolov <pet...@nucleusys.com> : [...] > > > + usb_fill_control_urb(async_urb, dev->udev, > > > + usb_sndctrlpipe(dev->udev, 0), (void *) &req->dr, > > > > Useless void * cast. > > Wrong. The compiler actually moans quite a lot: > > /usr/src/git/rtl8150/rtl8150.c: In function ?async_set_registers?: > /usr/src/git/rtl8150/rtl8150.c:92:9: warning: passing argument 4 of > ?usb_fill_control_urb? from incompatible pointer type [enabled by default] > In file included from /usr/src/git/rtl8150/rtl8150.c:17:0: > include/linux/usb.h:1440:20: note: expected ?unsigned char *? but argument is > of type ?struct usb_ctrlrequest *?
Sorry, I confused it with transfer_buffer. Some drivers go through unsigned char *, some widen it to void *. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
