On Wed, May 22, 2013 at 02:47:01PM -0500, Kent Yoder wrote: > >> + notify_remote_via_evtchn(priv->evtchn); > >> + > >> + ordinal = be32_to_cpu(*((__be32 *) (buf + 6))); > > > > Um, + 6? Why? Is there an #define for that magic constant? > > Should this value be read before you do the wait_for_tpm_stat stuff? > > This is hardcoded to 6 even in tpm.c. Time for a #define... > > > Otherwise it looks OK to me. Should this go through me or Kent? > > And if so, is Kent waiting for my feedback? > > My comments were minor -- I was expecting feedback on your earlier > comments before merging. I think this should go through the tpmdd > maintainer if its going to live in drivers/char/tpm though.
That is you I thought? konrad@phenom:~/mm$ scripts/get_maintainer.pl -f drivers/char/tpm Kent Yoder <[email protected]> (maintainer:TPM DEVICE DRIVER) Rajiv Andrade <[email protected]> (maintainer:TPM DEVICE DRIVER) Marcel Selhorst <[email protected]> (maintainer:TPM DEVICE DRIVER) Sirrix AG <[email protected]> (maintainer:TPM DEVICE DRIVER) [email protected] (moderated list:TPM DEVICE DRIVER) [email protected] (open list) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
