On May 27, 2013, at 8:05 PM, Nicolas Ferre <[email protected]> wrote:
> On 27/05/2013 12:48, Alexandre Belloni : >> Fixes: >> arch/arm/mach-at91/built-in.o: In function `ksz9021rn_phy_fixup': >> :(.text+0x1174): undefined reference to `mdiobus_write' >> :(.text+0x1188): undefined reference to `mdiobus_write' >> :(.text+0x119c): undefined reference to `mdiobus_write' >> :(.text+0x11b0): undefined reference to `mdiobus_write' >> arch/arm/mach-at91/built-in.o: In function `sama5_dt_device_init': >> :(.init.text+0x1e34): undefined reference to `phy_register_fixup_for_uid' >> >> when CONFIG_PHYLIB is not selected. >> >> Signed-off-by: Alexandre Belloni <[email protected]> >> Acked-by: Ludovic Desroches <[email protected]> >> --- >> Changes in v3: >> added SoB >> added Acked-By > > A v3 is not needed simply for this. Thanks, anyway! > > One question though: why not just add > > select PHYLIB > > In Kconfig entry: > > config MACH_SAMA5_DT > > ? > > (note that I like to play with everybody's nerves ;-)) > I prefer this than the IS_BUILTIN > Bye, > >> Changes in v2: >> use IS_BUILTIN >> use CONFIG_PHYLIB and not CONFIG_PHY >> >> arch/arm/mach-at91/board-dt-sama5.c | 22 ++++++++++++---------- >> 1 file changed, 12 insertions(+), 10 deletions(-) >> >> diff --git a/arch/arm/mach-at91/board-dt-sama5.c >> b/arch/arm/mach-at91/board-dt-sama5.c >> index 705305e..e9ce541 100644 >> --- a/arch/arm/mach-at91/board-dt-sama5.c >> +++ b/arch/arm/mach-at91/board-dt-sama5.c >> @@ -47,22 +47,24 @@ static int ksz9021rn_phy_fixup(struct phy_device *phy) >> #define GMII_ERCR 11 >> #define GMII_ERDWR 12 >> >> - /* Set delay values */ >> - value = GMII_RCCPSR | 0x8000; >> - phy_write(phy, GMII_ERCR, value); >> - value = 0xF2F4; >> - phy_write(phy, GMII_ERDWR, value); >> - value = GMII_RRDPSR | 0x8000; >> - phy_write(phy, GMII_ERCR, value); >> - value = 0x2222; >> - phy_write(phy, GMII_ERDWR, value); >> + if (IS_BUILTIN(CONFIG_PHYLIB)) { >> + /* Set delay values */ >> + value = GMII_RCCPSR | 0x8000; >> + phy_write(phy, GMII_ERCR, value); >> + value = 0xF2F4; >> + phy_write(phy, GMII_ERDWR, value); >> + value = GMII_RRDPSR | 0x8000; >> + phy_write(phy, GMII_ERCR, value); >> + value = 0x2222; >> + phy_write(phy, GMII_ERDWR, value); >> + } >> >> return 0; >> } >> >> static void __init sama5_dt_device_init(void) >> { >> - if (of_machine_is_compatible("atmel,sama5d3xcm")) >> + if (of_machine_is_compatible("atmel,sama5d3xcm") && >> IS_BUILTIN(CONFIG_PHYLIB)) >> phy_register_fixup_for_uid(PHY_ID_KSZ9021, MICREL_PHY_ID_MASK, >> ksz9021rn_phy_fixup); >> >> > > > -- > Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
