On Wed, May 29, 2013 at 03:35:28PM -0500, Mark Langsdorf wrote: > On 05/29/2013 03:12 PM, Timur Tabi wrote: > > On Wed, May 29, 2013 at 10:51 AM, Mark Langsdorf > > <[email protected]> wrote: > >> > >> { > >> - const unsigned long *timing = > >> sata_ehc_deb_timing(&link->eh_context); > >> + unsigned long timing[] = { 5, 100, 500}; > > > > > > You didn't address my comments the last time you posted this. I'll > > post them again: > > > > > > Why are you dropping the 'const'? > > > > Assuming it works, this should be more efficient: > > > > static const unsigned long timing[] = {5, 100, 500}; > > I thought there was a compile issue, but I just rechecked and there > wasn't. I'll fix for the next submission.
Also, please add a comment explaining why those parameters are necessary and how they're determined - ie. the bulk of the commit message; otherwise, it looks pretty random. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
