On Thu, May 30, 2013 at 06:24:37PM +0530, Kishon Vijay Abraham I wrote: > On Thursday 30 May 2013 05:02 PM, Mark Brown wrote: > >On Thu, May 30, 2013 at 04:26:33PM +0530, Kishon Vijay Abraham I wrote:
> >>Only compile tested. Just sent a patch to get some comments > >>/ideas on how to handle such one off regulators. > >>to handle > >What's unclear or confusing? This all looks really basic... > For instance mapping of regulator modes to smps10 modes is unclear. If you need clarification on that you need to ask a question about it. There is no question in your code. > >>+ palmas_smps_read(pmic->palmas, palmas_regs_info[id].ctrl_addr, ®); > >>+ reg &= ~PALMAS_SMPS10_CTRL_MODE_ACTIVE_MODE_MASK; > >>+ > >>+ if (mode == REGULATOR_MODE_NORMAL) > >>+ reg |= SMPS10_BOOST_EN; > >This looks like a switch statement and isn't there an update bits > >operation? > There can be multiple modes set at the same time. Having switch No they can't and if you check your code you'll see that it's correctly doing that - you're checking if the supplied mode is equal to a given value...
signature.asc
Description: Digital signature
