On Mon, Jun 3, 2013 at 12:07 PM, Jingoo Han <[email protected]> wrote: > The usage of strict_strtoul() is not preferred, because > strict_strtoul() is obsolete. Thus, kstrtoul() should be > used.
There is an issue, after fixing it take my Reviewed-by: Andy Shevchenko <[email protected]> > --- a/drivers/rtc/rtc-pcf2123.c > +++ b/drivers/rtc/rtc-pcf2123.c > @@ -117,9 +118,9 @@ static ssize_t pcf2123_store(struct device *dev, struct > device_attribute *attr, > > r = container_of(attr, struct pcf2123_sysfs_reg, attr); > > - if (strict_strtoul(r->name, 16, ®) > - || strict_strtoul(buffer, 10, &val)) > - return -EINVAL; > + ret = kstrtoul(r->name, 16, ®) || kstrtoul(buffer, 10, &val); This is not correct. Please, split to two sequential checks. > + if (ret) > + return ret; -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
