2.6.32-longterm review patch.  If anyone has any objections, please let me know.

------------------
 make_indexed_dir() fails

From: Allison Henderson <[email protected]>

Fix for a null pointer bug found while running punch hole tests

Signed-off-by: Allison Henderson <[email protected]>
Signed-off-by: "Theodore Ts'o" <[email protected]>
(cherry picked from commit 6976a6f2acde2b0443cd64f1d08af90630e4ce81)
Signed-off-by: Willy Tarreau <[email protected]>
---
 fs/ext4/namei.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index afe3148..902f69b 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -1457,6 +1457,10 @@ static int make_indexed_dir(handle_t *handle, struct 
dentry *dentry,
        frame->at = entries;
        frame->bh = bh;
        bh = bh2;
+
+       ext4_handle_dirty_metadata(handle, dir, frame->bh);
+       ext4_handle_dirty_metadata(handle, dir, bh);
+
        de = do_split(handle,dir, &bh, frame, &hinfo, &retval);
        if (!de) {
                /*
@@ -1465,8 +1469,6 @@ static int make_indexed_dir(handle_t *handle, struct 
dentry *dentry,
                 * with corrupted filesystem.
                 */
                ext4_mark_inode_dirty(handle, dir);
-               ext4_handle_dirty_metadata(handle, dir, frame->bh);
-               ext4_handle_dirty_metadata(handle, dir, bh);
                dx_release(frames);
                return retval;
        }
-- 
1.7.12.2.21.g234cd45.dirty



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to