On Wed, Jun 05, 2013 at 03:14:04PM +0800, Michael Wang wrote: > code refine to save some line. > > CC: Tejun Heo <[email protected]> > Signed-off-by: Michael Wang <[email protected]> > --- > kernel/workqueue.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/kernel/workqueue.c b/kernel/workqueue.c > index ee8e29a..5fd4791 100644 > --- a/kernel/workqueue.c > +++ b/kernel/workqueue.c > @@ -3417,9 +3417,8 @@ static bool wqattrs_equal(const struct workqueue_attrs > *a, > { > if (a->nice != b->nice) > return false; > - if (!cpumask_equal(a->cpumask, b->cpumask)) > - return false; > - return true; > + > + return cpumask_equal(a->cpumask, b->cpumask);
I don't know. I kinda like the current form because we can add new attributes easily without modifying existing lines. The suggested patch is frivolous. It doesn't really improve anything. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
