On Wed, Jun 05, 2013 at 12:50:45PM +0200, Matthias Schid wrote:
> fixed a linebreak within an error message string coding style
> issue reported by checkpatch.pl
>
> Signed-off-by: Matthias Schid <[email protected]>
> Signed-off-by: Stefan Huber <[email protected]>
> Signed-off-by: Simon Puels <[email protected]>
> ---
> drivers/staging/asus_oled/asus_oled.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/asus_oled/asus_oled.c
> b/drivers/staging/asus_oled/asus_oled.c
> index 173fb9a..a7cd65a 100644
> --- a/drivers/staging/asus_oled/asus_oled.c
> +++ b/drivers/staging/asus_oled/asus_oled.c
> @@ -383,8 +383,7 @@ static int append_values(struct asus_oled_dev *odev,
> uint8_t val, size_t count)
> }
>
> if (i >= odev->buf_size) {
> - dev_err(odev->dev, "Buffer overflow! Report a bug:"
> - "offs: %d >= %d i: %d (x: %d y: %d)\n",
> + dev_err(odev->dev, "Buffer overflow! Report a bug:
> offs: %d >= %d i: %d (x: %d y: %d)\n",
> (int) odev->buf_offs, (int) odev->buf_size,
> (int) i, (int) x, (int) y);
This could be improved:
dev_err(odev->dev,
"Buffer overflow! Report a bug: offs: %zu >= %d
i: %zu (x: %zu y: %zu)\n",
odev->buf_offs, odev->buf_size, i, x, y);
Printk fromats are documented in Documentation/printk-formats.txt.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
