On Wed, 5 Jun 2013 19:49:30 -0700 Kees Cook <keesc...@chromium.org> wrote:
> Avoid strncpy anti-pattern. Use strdup() instead, as already done for
> the logfile optarg.
>
What Andreas said :)
From: Andrew Morton <a...@linux-foundation.org>
Subject:
documentation-accounting-getdelaysc-avoid-strncpy-in-accounting-tool-fix
remove the str[cpy|dup] altogether
Cc: Andreas Schwab <sch...@linux-m68k.org>
Cc: Kees Cook <keesc...@chromium.org>
Cc: Rob Landley <r...@landley.net>
Signed-off-by: Andrew Morton <a...@linux-foundation.org>
---
Documentation/accounting/getdelays.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN
Documentation/accounting/getdelays.c~documentation-accounting-getdelaysc-avoid-strncpy-in-accounting-tool-fix
Documentation/accounting/getdelays.c
---
a/Documentation/accounting/getdelays.c~documentation-accounting-getdelaysc-avoid-strncpy-in-accounting-tool-fix
+++ a/Documentation/accounting/getdelays.c
@@ -299,7 +299,7 @@ int main(int argc, char *argv[])
break;
case 'C':
containerset = 1;
- containerpath = strdup(optarg);
+ containerpath = optarg;
break;
case 'w':
logfile = strdup(optarg);
_
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
