On 5/22/2013 12:40 PM, Philip Avinash wrote: > 1. Corrects coding and commenting styles > 2. Variables name change to meaningful name > 3. Remove unnecessary variable usage > 4. Add BINTEN macro definition > > Signed-off-by: Philip Avinash <avinashphi...@ti.com>
As Russell mentioned, the 80 char limit changes are churn. I looked at the variable name renaming and that's also churn with little benefit. The only changes that are probably worth doing are alphabetical ordering of include files, fixes for mult-line commenting style and usage of macro for register offset. As I started reviewing these patches, I also started fixing some of the comments I had and I have pushed the resulting work here: https://git.kernel.org/cgit/linux/kernel/git/nsekhar/linux-davinci.git/log/?h=devel-gpio It is only compile tested, but I hope this will serve as good starting point for your next submission. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/