On Tue, 2013-06-11 at 17:24 +0300, Eliezer Tamir wrote: > adds a socket option for low latency polling. > This allows overriding the global sysctl value with a per-socket one. [...] > --- a/net/core/sock.c > +++ b/net/core/sock.c > @@ -913,6 +913,23 @@ set_rcvbuf: > sock_valbool_flag(sk, SOCK_SELECT_ERR_QUEUE, valbool); > break; > > +#ifdef CONFIG_NET_LL_RX_POLL > + case SO_LL: > + if (!capable(CAP_NET_ADMIN)) > + ret = -EACCES; [...]
Failed capability checks normally result in EPERM whereas EACCES usually results from a file permission/ACL/label check. Perhaps unprivileged users should be allowed to set a value as long as it's less than or equal to the global value? Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
