[+ Hein] On Wed, 2013-06-12 at 13:42 +0530, Vinod Koul wrote: > On Wed, Jun 12, 2013 at 11:38:37AM +0300, Andy Shevchenko wrote: > > On Wed, Jun 12, 2013 at 10:52 AM, Vinod Koul <vinod.k...@intel.com> wrote: > > > On Wed, Jun 12, 2013 at 11:27:51AM +0300, Andy Shevchenko wrote: > > >> On Wed, Jun 12, 2013 at 10:39 AM, Vinod Koul <vinod.k...@intel.com> > > >> wrote: > > >> > > >> [] > > >> > > >> > Something like > > >> > config DW_DMAC_BIG_ENDIAN_IO > > >> > tristate > > >> > > > >> > config DW_DMAC > > >> > select DW_DMAC_BIG_ENDIAN_IO > > >> > > > >> > I belive DW_DMAC is for AVR support and the PCI ones is different > > >> > right. > > >> > The point is that these things should be selected by the required > > >> > symbols based > > >> > on what ARCH we are on and not be prompted for user to configure via > > >> > menuconfig > > >> > > >> DW_DMAC is a generic platform driver which supports AVR32, ARM and > > >> Intel (ACPI case) platforms. > > >> > > >> We may do that option invisible to user > > > Yup > > >> > > >> and then use > > >> > > >> config DW_DMAC > > >> select DW_DMAC_BIG_ENDIAN_IO if ARCH=AVR32 > > > Thats would be the right way > > > > Do you prefer to have this as separate patch or integrated in the split? > > In my humble opinion I better to do separate patch. > Never mind, am applying your patches and below fix, let me if you guys are > okay
As far as I know we have at least one developer (Hein Tibosch) with such board. Let him share his opinion. > > diff --git a/drivers/dma/dw/Kconfig b/drivers/dma/dw/Kconfig > index db2b41f..7be1cf8 100644 > --- a/drivers/dma/dw/Kconfig > +++ b/drivers/dma/dw/Kconfig > @@ -10,6 +10,7 @@ config DW_DMAC_CORE > config DW_DMAC > tristate "Synopsys DesignWare AHB DMA platform driver" > select DW_DMAC_CORE > + select DW_DMAC_BIG_ENDIAN_IO if ARCH=AVR32 > default y if CPU_AT32AP7000 > help > Support the Synopsys DesignWare AHB DMA controller. This > @@ -25,12 +26,4 @@ config DW_DMAC_PCI > Intel Medfield has integrated this GPDMA controller. > > config DW_DMAC_BIG_ENDIAN_IO > - bool "Use big endian I/O register access" > - default y if AVR32 > - depends on DW_DMAC_CORE > - help > - Say yes here to use big endian I/O access when reading and writing > - to the DMA controller registers. This is needed on some platforms, > - like the Atmel AVR32 architecture. > - > - If unsure, use the default setting. > + bool > - > > -- > ~Vinod -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
