On 6/12/2013 11:04 AM, Santosh Y wrote:
/** + * ufshcd_query_request() - API for issuing query request to the device. + * @hba: ufs driver context + * @query: params for query request + * @descriptor: buffer for sending/receiving descriptor + * @retries: number of times to try executing the command + * + * All necessary fields for issuing a query and receiving its response + * are stored in the UFS hba struct. We can use this method since we know + * there is only one active query request or any internal command at all + * times. + */ +static int ufshcd_send_query_request(struct ufs_hba *hba, + struct ufs_query_req *query, + u8 *descriptor, + struct ufs_query_res *response) +{ + int ret; + + BUG_ON(!hba); + if (!query || !response) { + dev_err(hba->dev, + "%s: NULL pointer query = %p, response = %p\n", + __func__, query, response); + return -EINVAL; + } + + mutex_lock(&hba->i_cmd.dev_cmd_lock); + hba->i_cmd.query.request = query; + hba->i_cmd.query.response = response; + hba->i_cmd.query.descriptor = descriptor; + + ret = ufshcd_exec_internal_cmd(hba, DEV_CMD_TYPE_QUERY, + QUERY_REQ_TIMEOUT);Can this be generic, as external query commands might also use it?
External query commands can call ufshcd_send_query_request() directly, without going into hassle of taking mutex lock and filling internal cmd structure.
+ + hba->i_cmd.query.request = NULL; + hba->i_cmd.query.response = NULL; + hba->i_cmd.query.descriptor = NULL; + mutex_unlock(&hba->i_cmd.dev_cmd_lock); + + return ret; +} + +/**
-- Regards, Sujit -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
