On Thu, Jun 13, 2013 at 9:33 PM, Joe Perches <j...@perches.com> wrote: > On Thu, 2013-06-13 at 21:25 +0300, Andy Shevchenko wrote: >> On Thu, Jun 13, 2013 at 5:37 PM, Alexey Brodkin >> <alexey.brod...@synopsys.com> wrote: >> > Driver for non-standard on-chip ethernet device ARC EMAC 10/100, >> > instantiated in some legacy ARC (Synopsys) FPGA Boards such as >> > ARCAngel4/ML50x.
>> > +++ b/drivers/net/ethernet/arc/arc_emac.h > [] >> > + if (unlikely((info & OWN_MASK) == FOR_EMAC)) { >> > + /* BD is still owned by EMAC */ >> > + continue; >> > + } >> >> Redundant braces. > > Maybe not. Braces can be a visual aid when there is > a comment in the test. I'm okay with both approaches. If author considers the comment is useful in that form, I agree with him. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/