On Wed, 2013-06-12 at 17:06 +0200, Arnd Bergmann wrote: > On Tuesday 11 June 2013, James Bottomley wrote: > > Really, no, it's not a good idea at all. It invites tons of patches > > littering the code with BUG_ONs where we might possibly get a NULL > > dereference. All it does is add extra instructions to a code path for > > no actual benefit. > > > > If you can answer the question: what more information does the BUG_ON > > give you than the NULL deref Oops would not? then it might be > > reasonable. > > The question is if a user can trigger the NULL dereference intentionally, > in which case they might get the kernel to jump into a user-provided > buffer.
Can you elaborate on how they could do this? If you're thinking they could alter the pointer and trigger the jump, then yes, but a BUG_ON won't prevent that because the altered pointer won't be NULL. James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
