On 06/14, Stephen Boyd wrote: > On 06/14, Rob Herring wrote: > > On 06/12/2013 12:21 PM, Stephen Boyd wrote: > > > On 06/11, Rob Herring wrote: > > >> Can you use vm_reserve_area_early here or perhaps just call > > >> iotable_init instead of create_mapping directly? I don't recall if > > >> there was some reason I didn't do that. > > >> > > > > > > I had iotable_init() before but I thought it was better to have > > > the ->caller argument say debug_ll_io_init() instead of > > > iotable_init(). Shall I extract out the similar code? > > > > Well, that's always welcome... > > > > Another option would be use __builtin_return_address. That would change > > vmallocinfo from showing iotable_init to the caller of iotable_init. > > Arguably, knowing the caller would be better. > > > > Ok sounds fair. I'll use iotable_init() and send a follow-up > patch to make iotable_init() more informative. >
Well now I get paging_init() as the function because that's where we're going to return to. That actually seems less informative. I'll do the similar code extraction. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
