On Sun, Jun 16, 2013 at 1:02 PM, Heiko Stübner <[email protected]> wrote:
>> > - *config = 0; >> > + pull = rockchip_get_pull(bank, pin - bank->pin_base); >> > + *config = (pull == param) ? 1 : 0; >> >> And then I guess you should emit PIN_CONFIG_BIAS_DISABLE >> here as well. > > rockchip_get_pull does emit PIN_CONFIG_BIAS_DISABLE when the pull is disabled, > only wrongly does add the argument here. Ah, right. > But I'm actually not quite sure what the expected behaviour is here at all :-) > > Say the pin is in the "pin-default" pull state and the query in config_get is > for "bias-disable", what would be the expected bahviour/return value in this > case? return -EINVAL; ? Hm it was some time since I designed this... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
