Hi Arnd, > -----Original Message----- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Monday, June 17, 2013 6:13 AM > To: Fernandes, Joel A > Cc: Tony Lindgren; Nori, Sekhar; Matt Porter; Grant Likely; Rob Herring; Vinod > Koul; Mark Brown; Cousson, Benoit; Russell King; Rob Landley; Andrew > Morton; Jason Kridner; Koen Kooi; Devicetree Discuss; Linux OMAP List; Linux > ARM Kernel List; Linux DaVinci Kernel List; Linux Kernel Mailing List; Linux > Documentation List; Linux MMC List; Linux SPI Devel List > Subject: Re: [PATCH v10 5/8] dmaengine: edma: Add TI EDMA device tree > binding > > On Friday 14 June 2013 21:32:47 Joel A Fernandes wrote: > > > > diff --git a/Documentation/devicetree/bindings/dma/ti-edma.txt > > b/Documentation/devicetree/bindings/dma/ti-edma.txt > > new file mode 100644 > > index 0000000..ada0018 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/dma/ti-edma.txt > > @@ -0,0 +1,26 @@ > > +TI EDMA > > + > > +Required properties: > > +- compatible : "ti,edma3" > > +- ti,hwmods: Name of the hwmods associated to the EDMA > > +- ti,edma-regions: Number of regions > > +- ti,edma-slots: Number of slots > > + > > +Optional properties: > > +- ti,edma-xbar-event-map: Crossbar event to channel map > > You need to list #dma-cells as required here, and which values are accepted > by the driver (I suppose only <1>). You should also explain the format of the > dma-specifier for a slave here for each possible value of #dma-cells. > > For each of the standard properties (reg, interrupts, dma-channels), list > whether they are optional or required. Since the example has three > interrupts, you should probably list how many interrupts need to be specified > (minimum and maximum if the number is variable) and in what order to > expect them. [Joel] Thanks for the suggestion, I updated it and it looks like this now: Required properties: - compatible : "ti,edma3" - ti,hwmods: Name of the hwmods associated to the EDMA - ti,edma-regions: Number of regions - ti,edma-slots: Number of slots - #dma-cells: Should be set to <1> Clients should use a single number per DMA channel request. - dma-channels: Specify total DMA channels per CC - reg: Memory map for accessing module - interrupt-parent: Interrupt controller the interrupt is routed through - interrupts: Exactly 3 interrupts need to be specified in the order: 1. Transfer completion interrupt. 2. Memory protection interrupt. 3. Error interrupt. Optional properties: - ti,edma-xbar-event-map: Crossbar event to channel map
Hope this looks ok. I will respin this patch and repost it in the next series spin. Thanks, Joel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
