On Mon, Jun 17, 2013 at 2:03 PM, Tony Lindgren <t...@atomide.com> wrote: > * Linus Walleij <linus.wall...@linaro.org> [130617 04:38]: >> On Fri, May 31, 2013 at 12:13 PM, Hebbar Gururaja >> <gururaja.heb...@ti.com> wrote: >> >> > Make pinctrl-single able to handle suspend/resume events and change >> > hogged pins states accordingly. >> > >> > Signed-off-by: Hebbar Gururaja <gururaja.heb...@ti.com> >> > Cc: Linus Walleij <linus.wall...@linaro.org> >> >> Noone said anything about this patch, but it looks very straight-forward >> to me and seems sound so I have applied it. >> >> If Tony or Haojian has strong feelings about it I will dequeue it. > > I don't like the hogged pins at all as they prevent me from unloading > pinctrl-single.. But the patch seems fine to me:
Hm? I think the hogged pins are the *only* pins we can reliably release when unloading the driver, look: void pinctrl_unregister(struct pinctrl_dev *pctldev) { (...) if (!IS_ERR(pctldev->p)) pinctrl_put(pctldev->p); That releases all hogged pinctrl handles when unloading a pinctrl driver. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/