On Mon, Jun 17, 2013 at 05:08:53PM +0100, Mark Brown wrote: > On Mon, Jun 17, 2013 at 04:04:52PM +0530, Tushar Behera wrote: > > On 06/17/2013 03:35 PM, Mark Brown wrote: > > > On Mon, Jun 17, 2013 at 02:42:25PM +0530, Tushar Behera wrote: > > > >> Ping. > i > > > Don't send contentless pings. I seem to recall you already got some > > > review on this. > > > > > The comment was on removal of the error message during > > devm_ioremap_resource() error check . Since there are a few other error > > messages in the driver (related to devm_ioremap_nocache) in the same > > format, I prefer to leave this error message right now. > > So we should say the same thing repeatedly? That seems silly. That > seems silly. It's like the contentless pings issue...
The intention was to make resource usage more consistent with the new devm_ioremap_resource(). Part of the consistency involved to move all error messages into the function so that callers shouldn't have to worry about them anymore. So I agree with Mark that there's really no use in keeping a second copy of the error message. Thierry
pgp1uCqCB0l_C.pgp
Description: PGP signature
