On Mon, Jun 17, 2013 at 9:40 AM, Russell King - ARM Linux <[email protected]> wrote: > On Mon, Jun 17, 2013 at 01:43:19AM +0100, Grant Likely wrote: >> The machine desc structure has a hook for doing machine-specific >> memblock code, but the SA1111 still has a platform-specific hook in the >> generic code. This patch merely moves the needed memblock_reserve() >> into a callback. > > And... the reason I left this in generic code was to avoid the problem > which you've created by doing this change - there is at least one PXA > platform which also can have SA1111 enabled, and by omitting this > reservation, you will make that platform blow up at boot time because > we will try and free the same region of RAM twice into the buddy > allocator. > > It was left there because one of these currently has to stay in generic > code, so they both need to in order to ensure that both are properly > paired. > > What problem, other than a distaste for having such things in generic > code, are you having with this?
Merely trying to clean up generic code. That's all. It was something I noticed that would be nice to clean up. I could remove it I suppose by adding a new machine_desc hook, but it's not worth adding another callback for exactly one user. I'm not going to bother spending any more time on this. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
