On Wed, Jun 19, 2013 at 02:22:59PM +0530, Viresh Kumar wrote: > PRECHANGE and POSTCHANGE notifiers must be called in groups, i.e either both > should be called or both shouldn't be. > > In case we have started PRECHANGE notifier and found an error, we must call > POSTCHANGE notifier with freqs.new = freqs.old to guarantee that sequence of > calling notifiers is complete. > > This driver was taking care of it but frequency isn't restored to freqs.old. > > This patch fixes it. > > Cc: Simon Horman <[email protected]> > Signed-off-by: Viresh Kumar <[email protected]>
I have no objections to this change but at the same time I don't feel that I know the code well enough to review it. > --- > drivers/cpufreq/e_powersaver.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/cpufreq/e_powersaver.c b/drivers/cpufreq/e_powersaver.c > index 37380fb..3d03626 100644 > --- a/drivers/cpufreq/e_powersaver.c > +++ b/drivers/cpufreq/e_powersaver.c > @@ -161,6 +161,9 @@ postchange: > current_multiplier); > } > #endif > + if (err) > + freqs.new = freqs.old; > + > cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE); > return err; > } > -- > 1.7.12.rc2.18.g61b472e > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
