On Wed, Jun 19, 2013 at 06:17:36PM +0800, Chen Gang wrote: > Hmm... can 'worker->task' has chance to be not NULL before set 'current' > to it ?
Yes, if the caller screws up and try to attach more than one workers to the kthread_worker, which has some possibility of happening as kthread_worker allows both attaching and detaching a worker. > why do we use WARN_ON(worker->task) ? To detect bugs on the caller side. > I guess it still has chance to let "worker->task != NULL", or it should > be BUG_ON(worker->task) instead of. What difference does that make? -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
