On 06/24/2013 01:29 PM, Linus Walleij wrote: > On Thu, Jun 20, 2013 at 4:05 PM, <patrice.chotard...@gmail.com> wrote: > >> From: Patrice Chotard <patrice.chot...@st.com> >> >> Replace hardcoded value by corresponding #define's. >> >> Signed-off-by: Patrice Chotard <patrice.chot...@st.com> > > This is not so good. The commit message is saying it > replaces values by #defines but is actually replacing it > by an enum. > > Then you're in each instance calling > > abx500_gpio_set_bits(struct gpio_chip *chip, u8 reg, > unsigned offset, int val) > > The last argument is a hardware register value, but here you > case an enum abx500_gpio_direction to an integer and pass > to this function. > > It would be better if the patch did what it says: create a > #define for ABX500_GPIO_INPUT and ABX500_GPIO_OUTPUT > locally in drivers/pinctrl/pinctrl-abx500.c and use it locally > instead of touching <mfd/abx500/ab8500-gpio.h>.
Ok, i'll resubmit this > > Thanks, > Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
