Jean, Michal, All, On 2013-06-24 09:57 +0200, Jean Delvare spake thusly: > Le Wednesday 19 June 2013 à 00:45 +0200, Yann E. MORIN a écrit : > > When searching for symbols, return the symbols sorted by relevance. > > > > Sorting is done as thus: > > - first, symbols with a prompt, [1] > > - then, smallest offset, [2] > > - then, shortest match, [3] > > - then, highest relative match, [4] > > - finally, alphabetical sort [5] > > > > So, searching (eg.) for 'P.*CI' : > > Nobody would actually search for that, so that's not a particularly good > example to determine whether your sort order is sane or not.
Yes, this was just to explain the sorting algorithm with a simple example. [--SNIP--] > > This heuristic tries hard to get interesting symbols first in the list. > > I know I am the one whose question triggered this work from you, but in > the end the "response" seems disproportionate. Having 5 different > ordering rules is a lot, and that's quite a bit of code, which while not > the most complex in the world, is still far from trivial and may require > maintenance work in the future. OK, I understand you concerns. Michal, please do not apply this patch: I'll rewrite it with a simpler heuristic as Jean suggested, and will re-submit a complete pull-request later tonight. > So I think it is more important to make it clearer that regular > expressions are allowed, than to come up with a brilliant sort order. I > know the help page says it, but the prompt itself only asks for a > "(sub)string" and it is not immediately obvious (to me at least) that > regular expressions are considered substrings. OK, Ill see to rewite the title of the dialog box. Thanks for the review! Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
