Hi Jean Christophe, On Mon, Jun 24, 2013 at 04:26:45PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 20:27 Fri 21 Jun , Alexandre Belloni wrote: > > From: Maxime Ripard <[email protected]> > > > > Signed-off-by: Alexandre Belloni <[email protected]> > > Signed-off-by: Maxime Ripard <[email protected]> > > --- > > drivers/video/backlight/hx8357.c | 53 > > +++++++++++++++++++++++----------------- > > 1 file changed, 31 insertions(+), 22 deletions(-) > > > > diff --git a/drivers/video/backlight/hx8357.c > > b/drivers/video/backlight/hx8357.c > > index a0482b5..69f5672 100644 > > --- a/drivers/video/backlight/hx8357.c > > +++ b/drivers/video/backlight/hx8357.c > > @@ -76,6 +76,7 @@ struct hx8357_data { > > unsigned reset; > > struct spi_device *spi; > > int state; > > + u8 use_im_pins; > boolean please
Ok.
> > };
> >
> > static u8 hx8357_seq_power[] = {
> > @@ -250,9 +251,11 @@ static int hx8357_lcd_init(struct lcd_device *lcdev)
> > * Set the interface selection pins to SPI mode, with three
> > * wires
> > */
> > - gpio_set_value_cansleep(lcd->im_pins[0], 1);
> > - gpio_set_value_cansleep(lcd->im_pins[1], 0);
> > - gpio_set_value_cansleep(lcd->im_pins[2], 1);
> > + if (lcd->use_im_pins) {
> > + gpio_set_value_cansleep(lcd->im_pins[0], 1);
> > + gpio_set_value_cansleep(lcd->im_pins[1], 0);
> > + gpio_set_value_cansleep(lcd->im_pins[2], 1);
> > + }
>
> base on the dt probe you may have gpios betwee 0 to HX8357_NUM_IM_PINS
>
> so this look wrong
How so?
HX8357_NUM_IM_PINS is defined to 3, the probe checks to see if we
actually have HX8357_NUM_IM_PINS, otherwise returns an error, what is
wrong in setting these pins here?
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
signature.asc
Description: Digital signature
