On Tue, Jun 25, 2013 at 08:46:12PM +0530, Vinod Koul wrote: > On Sat, Jun 22, 2013 at 10:42:33PM +0200, Tomasz Figa wrote: > > - BUG_ON(clli < llis_bus || clli >= llis_bus + > > + llis_va = txd->llis_va; > > + llis_bus = txd->llis_bus; > > + > > + BUG_ON(clli < llis_bus || clli >= llis_bus + > > sizeof(struct pl08x_lli) * MAX_NUM_TSFR_LLIS); > IMO BUG_ON is too much for this. Perhaps returning error and logging error > would > be okay
That should be a separate patch, because that's an unrelated change to this patch. As this part is just reformatting this part of the code, it should contain no actual changes. There's lots that this driver "should" do differently... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
