In a message of Wed, 26 Jun 2013 10:21:22 -0700, Greg Kroah-Hartman writes: >On Tue, Jun 25, 2013 at 11:39:26PM +0200, Anders Hammarquist wrote: >> In a message of Tue, 25 Jun 2013 11:39:32 -0700, Greg Kroah-Hartman writes: >> >3.0-stable review patch. If anyone has any objections, please let me know. >> > >> >From: Anders Hammarquist <i...@iko.pp.se> >> > >> >commit 35a2fbc941accd0e9f1bfadd669311786118d874 upstream. >> > >> >Add product id for Abbott strip port cable for Precision meter which >> >uses the TI 3410 chip. >> >> Given the statically sized arrays, I think this patch should not go in >> alone. It needs to go together with the later patches I sent you that >> fix the array sizing. >> >> (this applies to all trees) > >Yes, but, thanks to the fact that you are only adding one more device >id, I don't think we are overflowing anything with this patch alone, >right? The only "bad" thing that could happen here is if a user >specifies a device/vendor id on the module command line, is it would >replace the device id you added, so all should be fine. > >Or am I reading the code wrong?
I'm reading the code the same way you are. From what I can see there is no place that counts on there enough space beyond the last entry, so nothing truly bad should happen. /Anders -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
