Hi Hans, Thanks for the review.
On Thu, Jun 27, 2013 at 11:27 AM, Hans Verkuil <[email protected]> wrote: > On Tue June 25 2013 17:17:34 Prabhakar Lad wrote: >> From: "Lad, Prabhakar" <[email protected]> >> >> Add support for asynchronous subdevice probing, using the v4l2-async API. >> The legacy synchronous mode is still supported too, which allows to >> gradually update drivers and platforms. >> >> Signed-off-by: Prabhakar Lad <[email protected]> >> Cc: Guennadi Liakhovetski <[email protected]> >> Cc: Hans Verkuil <[email protected]> >> Cc: Laurent Pinchart <[email protected]> >> Cc: Sakari Ailus <[email protected]> >> Cc: Mauro Carvalho Chehab <[email protected]> >> --- >> drivers/media/platform/davinci/vpif_capture.c | 151 >> +++++++++++++++++-------- >> drivers/media/platform/davinci/vpif_capture.h | 2 + >> include/media/davinci/vpif_types.h | 2 + >> 3 files changed, 107 insertions(+), 48 deletions(-) >> >> diff --git a/drivers/media/platform/davinci/vpif_capture.c >> b/drivers/media/platform/davinci/vpif_capture.c >> index 5514175..b11d7a7 100644 >> --- a/drivers/media/platform/davinci/vpif_capture.c >> +++ b/drivers/media/platform/davinci/vpif_capture.c >> @@ -1979,6 +1979,76 @@ vpif_init_free_channel_objects: >> return err; >> } >> >> +static int vpif_async_bound(struct v4l2_async_notifier *notifier, >> + struct v4l2_subdev *subdev, >> + struct v4l2_async_subdev *asd) >> +{ >> + int i; >> + >> + for (i = 0; i < vpif_obj.config->subdev_count; i++) >> + if (!strcmp(vpif_obj.config->subdev_info[i].name, >> + subdev->name)) { > > Since the subdev name is now prefixed with the i2c bus identifier instead of > just the chip name, does this code still work? Shouldn't it be 'strstr' > instead > of strcmp? Ditto for vpif_display and possibly others where the same > mechanism might be used. > This is because the DA850-EVM has two tvp514x devices and assigning the tvp514x device to appropriate channel is important, In this case strstr() wont work so I used strcmp instead to match it appropriately. Yes the code still works tested on DA850-EVM, with this patch [1]. [1] http://git.linuxtv.org/mhadli/v4l-dvb-davinci_devices.git/commitdiff/c906a89762541361158cf73e9494fa2f1ff8ba02 Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
