Am 26.06.2013 23:34, schrieb Alexander Holler:
Am 26.06.2013 21:55, schrieb Andrew Morton:
On Thu, 20 Jun 2013 12:39:36 +0200 Alexander Holler <[email protected]>
wrote:
+static void hid_time_register_rtc_work(struct work_struct *work)
+{
+ struct hid_time_state *time_state =
+ container_of(work, struct hid_time_workts, work)
+ ->time_state;
+ struct platform_device *pdev = time_state->callbacks.pdev;
Ick. When the initialisers overflow 80 cols, the fix is easy: don't
use initalisers:
struct hid_time_state *time_state;
struct platform_device *pdev;
time_state = container_of(work, struct hid_time_workts,
work)->time_state;
pdev = time_state->callbacks.pdev;
Sorry, but it's long ago since I had to use a DOS machine and I still
don't use a phone to write source, therefor I'm not very skilled in
writing readable source with meaningfull names in max. 72 (80-8) chars
per line. But I will work hard to relearn those long forgotten skills,
they might become handy again, when PCs with monitors got finally
replaced by phones and tablets with small screens. ;)
To do other poor patch submitters which don't use a video terminal too a
favor, I've decided it might make sense to describe the workflow which
is responsible for the above stuff which makes you cry so often. It
isn't that I don't know that I don't have to use initializers, I know C
since 3 decades.
The following happens here:
- I'm writing source/patches without limiting myself to 80x25 chars.
- Then I'm executing the insulting and must be one of the most hated
piece of software callled checkpatch.pl.
- It tells me to place or delete spaces here and cut lines there.
- I do exactly that, while having my brain turned off (self-protection)
Therefor stuff the like the above happens. It isn't badwill,
incompetence or inability.
Regards,
Alexander Holler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
