Hi Ramkumar, On Thu, 4 Jul 2013 19:10:46 +0530, Ramkumar Ramachandra wrote: > Currently, a simple > > $ make > > errors out because we compile with -Werror by default, turning all > warnings into errors. Although no warnings are emitted by our code > itself, two kinds of warnings are emitted by perl.h (perl 5.18.0): > > -Wundef and -Wswitch-default
IIRC there's a floating patch for this, but I cannot find it now. > > Use #pragma statements to squelch exactly those warnings, and get perf > to compile-pass by default. > > Cc: Arnaldo Carvalho de Melo <a...@redhat.com> > Cc: Namhyung Kim <namhyung....@lge.com> > Signed-off-by: Ramkumar Ramachandra <artag...@gmail.com> > --- > tools/perf/config/feature-tests.mak | 5 +++++ > tools/perf/scripts/perl/Perf-Trace-Util/Context.c | 10 ++++++++-- > tools/perf/scripts/perl/Perf-Trace-Util/Context.xs | 10 ++++++++-- > tools/perf/util/scripting-engines/trace-event-perl.c | 5 +++++ > 4 files changed, 26 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/config/feature-tests.mak > b/tools/perf/config/feature-tests.mak > index 708fb8e..91fa083 100644 > --- a/tools/perf/config/feature-tests.mak > +++ b/tools/perf/config/feature-tests.mak > @@ -103,7 +103,12 @@ endif > ifndef NO_LIBPERL > define SOURCE_PERL_EMBED > #include <EXTERN.h> > + > +#pragma GCC diagnostic ignored \"-Wundef\" > +#pragma GCC diagnostic ignored \"-Wswitch-default\" > #include <perl.h> > +#pragma GCC diagnostic error \"-Wundef\" > +#pragma GCC diagnostic error \"-Wswitch-default\" It seems that this kind of duplication is not a good solution. You'd better making an wraping header like ui/gtk/gtk.h. Thanks, Namhyung > > int main(void) > { > diff --git a/tools/perf/scripts/perl/Perf-Trace-Util/Context.c > b/tools/perf/scripts/perl/Perf-Trace-Util/Context.c > index 790ceba..0807294 100644 > --- a/tools/perf/scripts/perl/Perf-Trace-Util/Context.c > +++ b/tools/perf/scripts/perl/Perf-Trace-Util/Context.c > @@ -28,8 +28,14 @@ > * > */ > > -#include "EXTERN.h" > -#include "perl.h" > +#include <EXTERN.h> > + > +#pragma GCC diagnostic ignored "-Wundef" > +#pragma GCC diagnostic ignored "-Wswitch-default" > +#include <perl.h> > +#pragma GCC diagnostic error "-Wundef" > +#pragma GCC diagnostic error "-Wswitch-default" > + > #include "XSUB.h" > #include "../../../perf.h" > #include "../../../util/trace-event.h" > diff --git a/tools/perf/scripts/perl/Perf-Trace-Util/Context.xs > b/tools/perf/scripts/perl/Perf-Trace-Util/Context.xs > index c1e2ed1..cd46e01 100644 > --- a/tools/perf/scripts/perl/Perf-Trace-Util/Context.xs > +++ b/tools/perf/scripts/perl/Perf-Trace-Util/Context.xs > @@ -19,8 +19,14 @@ > * > */ > > -#include "EXTERN.h" > -#include "perl.h" > +#include <EXTERN.h> > + > +#pragma GCC diagnostic ignored "-Wundef" > +#pragma GCC diagnostic ignored "-Wswitch-default" > +#include <perl.h> > +#pragma GCC diagnostic error "-Wundef" > +#pragma GCC diagnostic error "-Wswitch-default" > + > #include "XSUB.h" > #include "../../../perf.h" > #include "../../../util/script-event.h" > diff --git a/tools/perf/util/scripting-engines/trace-event-perl.c > b/tools/perf/util/scripting-engines/trace-event-perl.c > index eacec85..aa3c11e 100644 > --- a/tools/perf/util/scripting-engines/trace-event-perl.c > +++ b/tools/perf/util/scripting-engines/trace-event-perl.c > @@ -27,7 +27,12 @@ > > #include "../util.h" > #include <EXTERN.h> > + > +#pragma GCC diagnostic ignored "-Wundef" > +#pragma GCC diagnostic ignored "-Wswitch-default" > #include <perl.h> > +#pragma GCC diagnostic error "-Wundef" > +#pragma GCC diagnostic error "-Wswitch-default" > > #include "../../perf.h" > #include "../thread.h" -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/