On 07/05/2013 06:23 PM, Arnd Bergmann wrote: > The call to local_timer_register is hidden behind an #ifdef, which > turns the armada_370_xp_local_timer_ops into a potentially unused > variable, causing this warning: > > time-armada-370-xp.c:208:31: warning: 'armada_370_xp_local_timer_ops' defined > but not used [-Wunused-variable] > static struct local_timer_ops armada_370_xp_local_timer_ops __cpuinitdata = { > ^ > > Since local_timer_register() itself doesn't do anything, just removing > the #ifdef makes the code look nicer and gets rid of the warning. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Acked-by: Jason Cooper <ja...@lakedaemon.net> > Cc: Gregory CLEMENT <gregory.clem...@free-electrons.com> > --- > drivers/clocksource/time-armada-370-xp.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/clocksource/time-armada-370-xp.c > b/drivers/clocksource/time-armada-370-xp.c > index 47a6730..4cd8520 100644 > --- a/drivers/clocksource/time-armada-370-xp.c > +++ b/drivers/clocksource/time-armada-370-xp.c > @@ -294,8 +294,6 @@ void __init armada_370_xp_timer_init(void) > percpu_armada_370_xp_evt); > if (!res) { > enable_percpu_irq(armada_370_xp_clkevt.irq, 0); > -#ifdef CONFIG_LOCAL_TIMERS > local_timer_register(&armada_370_xp_local_timer_ops); > -#endif > } > } >
I thought this issue was kind of fixed by the patch "clocksource: time-armada-370-xp: Divorce from local timer API" from Stephen Boyd. But I can't find it in linux-next so maybe it has not been pulled, so in this case you can also add my Acked-by: Gregory CLEMENT <gregory.clem...@free-electrons.com> -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/