From: Ulrich Prinz <ulrich.pr...@googlemail.com>

Some variants of SOCs using dw_apb_timer have inverted logic for the
bit that sets one-shot / periodic mode or free running timer. This
commit adds the new APBTMR_QUIRK_INVERSE_PERIODIC.

Signed-off-by: Ulrich Prinz <ulrich.pr...@googlemail.com>
---
 drivers/clocksource/dw_apb_timer.c |   11 +++++++++--
 include/linux/dw_apb_timer.h       |    6 ++++++
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/drivers/clocksource/dw_apb_timer.c 
b/drivers/clocksource/dw_apb_timer.c
index 7705d13..a2e8306 100644
--- a/drivers/clocksource/dw_apb_timer.c
+++ b/drivers/clocksource/dw_apb_timer.c
@@ -159,7 +159,11 @@ static void apbt_set_mode(enum clock_event_mode mode,
        case CLOCK_EVT_MODE_PERIODIC:
                period = DIV_ROUND_UP(timer->freq, HZ);
                ctrl = apbt_readl(timer, timer->reg_control);
-               ctrl |= APBTMR_CONTROL_MODE_PERIODIC;
+
+               if (timer->quirks & APBTMR_QUIRK_INVERSE_PERIODIC)
+                       ctrl &= ~APBTMR_CONTROL_MODE_PERIODIC;
+               else
+                       ctrl |= APBTMR_CONTROL_MODE_PERIODIC;
                apbt_writel(timer, ctrl, timer->reg_control);
                /*
                 * DW APB p. 46, have to disable timer before load counter,
@@ -186,7 +190,10 @@ static void apbt_set_mode(enum clock_event_mode mode,
                 * the next event, therefore emulate the one-shot mode.
                 */
                ctrl &= ~APBTMR_CONTROL_ENABLE;
-               ctrl &= ~APBTMR_CONTROL_MODE_PERIODIC;
+               if (timer->quirks & APBTMR_QUIRK_INVERSE_PERIODIC)
+                       ctrl |= APBTMR_CONTROL_MODE_PERIODIC;
+               else
+                       ctrl &= ~APBTMR_CONTROL_MODE_PERIODIC;
 
                apbt_writel(timer, ctrl, timer->reg_control);
                /* write again to set free running mode */
diff --git a/include/linux/dw_apb_timer.h b/include/linux/dw_apb_timer.h
index 7d36d91..5d9210cc 100644
--- a/include/linux/dw_apb_timer.h
+++ b/include/linux/dw_apb_timer.h
@@ -36,6 +36,12 @@
  */
 #define APBTMR_QUIRK_INVERSE_INTMASK   BIT(2)
 
+/* The IP uses inverted logic for the bit setting periodic mode.
+ * Periodic means it times out after the period is over and is set to
+ * 1 in the original IP. This IP uses 1 for free running mode.
+ */
+#define APBTMR_QUIRK_INVERSE_PERIODIC  BIT(3)
+
 struct dw_apb_timer {
        void __iomem                            *base;
        unsigned long                           freq;
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to