On 07/09/2013 04:07 PM, Rusty Russell wrote:
> Chen Gang <gang.c...@asianux.com> writes:
>> When sysfs_create_file() fails, recommend to print the related failure
>> information. And it is useless to still 'KOBJ_ADD' to user space.
>>
>> Signed-off-by: Chen Gang <gang.c...@asianux.com>
>
> sysfs_create_file() should not fail during boot, should it?
>
Hmm..., please reference locate_module_kobject() in "kernel/params.c",
which is an '__init' function, and also call sysfs_create_file(), it
processes the related error.
So I recommend to get the check too in version_sysfs_builtin().
Thanks.
> Cheers,
> Rusty.
>
>> ---
>> kernel/params.c | 8 +++++++-
>> 1 files changed, 7 insertions(+), 1 deletions(-)
>>
>> diff --git a/kernel/params.c b/kernel/params.c
>> index 440e65d..f5299c1 100644
>> --- a/kernel/params.c
>> +++ b/kernel/params.c
>> @@ -845,7 +845,13 @@ static void __init version_sysfs_builtin(void)
>> mk = locate_module_kobject(vattr->module_name);
>> if (mk) {
>> err = sysfs_create_file(&mk->kobj, &vattr->mattr.attr);
>> - kobject_uevent(&mk->kobj, KOBJ_ADD);
>> + if (err)
>> + printk(KERN_WARNING
>> + "%s (%d): sysfs_create_file fail for %s,
>> err: %d\n",
>> + __FILE__, __LINE__,
>> + vattr->module_name, err);
>> + else
>> + kobject_uevent(&mk->kobj, KOBJ_ADD);
>> kobject_put(&mk->kobj);
>> }
>> }
>> --
>> 1.7.7.6
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Chen Gang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
