On Wed, Jul 10, 2013 at 03:57:30PM -0700, Greg Kroah-Hartman wrote: > On Wed, Jul 10, 2013 at 03:48:56PM -0700, Guenter Roeck wrote: > > On Wed, Jul 10, 2013 at 01:05:10PM -0700, Greg Kroah-Hartman wrote: > > > To make it easier for driver subsystems to work with attribute groups, > > > create the ATTRIBUTE_GROUPS macro to remove some of the repetitive > > > typing for the most common use for attribute groups. > > > > > > Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> > > > --- > > > include/linux/sysfs.h | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h > > > index 9cd20c8..f62ff01 100644 > > > --- a/include/linux/sysfs.h > > > +++ b/include/linux/sysfs.h > > > @@ -94,6 +94,15 @@ struct attribute_group { > > > #define __ATTR_IGNORE_LOCKDEP __ATTR > > > #endif > > > > > > +#define ATTRIBUTE_GROUPS(name) \ > > > > Would it be possible to add is_visible as additional argument ? > > I thought about the other options (multiple groups, is_visible, and > bin_attrs), but those are almost all not the "normal" usage, so I figure > it's worth the extra 6 lines of text if you want to support is_visible > or binary attributes. > Ok, fair enough.
Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/