On 07/12/2013 09:41 AM, Steven Rostedt wrote: > On Fri, 2013-07-12 at 07:51 +0800, Chen Gang wrote: > >> > Hmm, can all trace_selftest_startup_* (*selftest* in trace_selftest.c) >> > use '__init', so not waste memory keeping them around ? > Yeah, they should all be set to __init, but that's pretty low on the > totem poll, as distros don't enable selftests in their main kernels.
Excuse me, my English is not quite well, I guess your meaning is: they should all be set to '__init', although it is minor in real world. Is it correct ? For me, I recommend to let all *selftest* as the same: "all add ' __init' or none add '__init'" (if choose add, all report warnings). Is it suitable to still send new related patch for it ? If so, could you provide your suggesting choice (all add, or none add) ? Thanks. -- Chen Gang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/