> -----Original Message----- > From: Ben Hutchings [mailto:b...@decadent.org.uk] > Sent: Friday, July 12, 2013 5:13 PM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com; Stable > Subject: Re: [PATCH 1/2] Drivers: hv: balloon: Fix a bug in the hot-add code > > On Fri, Jul 12, 2013 at 09:07:19PM +0000, KY Srinivasan wrote: > [...] > > > Well now it might look like a bug that you don't test the result > > > of wait_for_completion_timeout(). Maybe update the comment to > > > explain why it's OK to continue anyway? > > > > I put in the comment in the patch explaining why it is ok to continue. > [...] > > But that is not nearly as easy to see as the comment that is > already *in the code* which your patch isn't updating.
Agreed; I will resend the patch with comments added. Thanks, K. Y > > Ben. > > -- > Ben Hutchings > We get into the habit of living before acquiring the habit of thinking. > - Albert Camus > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
