On 07/17/2013 07:23 PM, Steven Rostedt wrote:
> On Wed, 2013-07-17 at 17:03 -0600, Shuah Khan wrote:
>
>> diff --git a/include/trace/events/power.h b/include/trace/events/power.h
>> index 8e42410..24afd22 100644
>> --- a/include/trace/events/power.h
>> +++ b/include/trace/events/power.h
>> @@ -66,6 +66,41 @@ TRACE_EVENT(machine_suspend,
>> TP_printk("state=%lu", (unsigned long)__entry->state)
>> );
>>
>> +TRACE_EVENT(device_pm_report_time,
>> +
>> + TP_PROTO(const char *device, const char *driver, const char *parent,
>> + const char *pm_ops, s64 ops_time, char *pm_event_str,
>> + int error),
>> +
>> + TP_ARGS(device, driver, parent, pm_ops, ops_time, pm_event_str, error),
>> +
>> + TP_STRUCT__entry(
>> + __string(device, device)
>> + __string(driver, driver)
>> + __string(parent, parent)
>> + __string(pm_ops, pm_ops)
>> + __string(pm_event_str, pm_event_str)
>> + __field(s64, ops_time)
>> + __field(int, error)
>> + ),
>> +
>> + TP_fast_assign(
>> + __assign_str(device, device);
>> + __assign_str(driver, driver);
>> + __assign_str(parent, parent);
>> + __assign_str(pm_ops, pm_ops);
>> + __assign_str(pm_event_str, pm_event_str);
>> + __entry->ops_time = ops_time;
>> + __entry->error = error;
>> + ),
>> +
>> + /* ops_str has an extra space at the end */
>> + TP_printk("%s %s parent=%s state=%s ops=%snsecs=%lld err=%d",
>> + __get_str(driver), __get_str(device), __get_str(parent),
>> + __get_str(pm_event_str), __get_str(pm_ops),
>> + __entry->ops_time, __entry->error)
>
>
> Don't you want to convert the ops_time on display? You can have:
>
> TP_printk("%s %s parent=%s state=%s ops=%snsecs=%lld err=%d",
> __get_str(driver), __get_str(device), __get_str(parent),
> __get_str(pm_event_str), __get_str(pm_ops),
> ktime_to_ns(__entry->ops_time), __entry->error)
>
>
> -- Steve
I decided to pass in the converted value to the tracepoint. Please see
the drivers/base/power/main.c call to trace_device_pm_report_time()
+
+ trace_device_pm_report_time(dev_name(dev), dev_driver_string(dev),
+ dev->parent ? dev_name(dev->parent) : "none",
+ info ? info : "none ",
+ (s64) ktime_to_ns(delta), pm_verb(state.event),
+ error);
-- Shuah
Shuah Khan, Linux Kernel Developer - Open Source Group Samsung Research
America (Silicon Valley) [email protected] | (970) 672-0658
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
