Commit-ID:  5888a8c26e5f8e76334d579637f9ed55036cec5a
Gitweb:     http://git.kernel.org/tip/5888a8c26e5f8e76334d579637f9ed55036cec5a
Author:     Jiri Olsa <[email protected]>
AuthorDate: Fri, 7 Jun 2013 15:37:02 +0200
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Fri, 12 Jul 2013 13:45:50 -0300

perf tests: Omit end of the symbol check failure for test 1

Omitting end of the function check failure for test 1, since there's no
way to get exact symbol end via kallsyms.

Leaving the debug message.

Signed-off-by: Jiri Olsa <[email protected]>
Cc: Andi Kleen <[email protected]>
Cc: Corey Ashford <[email protected]>
Cc: David Ahern <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: 
http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
 tools/perf/tests/vmlinux-kallsyms.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/tools/perf/tests/vmlinux-kallsyms.c 
b/tools/perf/tests/vmlinux-kallsyms.c
index 7b4c4d2..add1539 100644
--- a/tools/perf/tests/vmlinux-kallsyms.c
+++ b/tools/perf/tests/vmlinux-kallsyms.c
@@ -139,11 +139,18 @@ next_pair:
                                 * _really_ have a problem.
                                 */
                                s64 skew = sym->end - pair->end;
-                               if (llabs(skew) < page_size)
-                                       continue;
+                               if (llabs(skew) >= page_size)
+                                       pr_debug("%#" PRIx64 ": diff end addr 
for %s v: %#" PRIx64 " k: %#" PRIx64 "\n",
+                                                sym->start, sym->name, 
sym->end, pair->end);
+
+                               /*
+                                * Do not count this as a failure, because we
+                                * could really find a case where it's not
+                                * possible to get proper function end from
+                                * kallsyms.
+                                */
+                               continue;
 
-                               pr_debug("%#" PRIx64 ": diff end addr for %s v: 
%#" PRIx64 " k: %#" PRIx64 "\n",
-                                        sym->start, sym->name, sym->end, 
pair->end);
                        } else {
                                struct rb_node *nnd;
 detour:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to