On 07/18/2013 04:53 PM, Steven Rostedt wrote: > On Thu, 2013-07-18 at 16:42 -0600, Shuah Khan wrote: > >> +TRACE_EVENT(device_pm_report_time, >> + >> + TP_PROTO(struct device *dev, const char *pm_ops, s64 ops_time, >> + char *pm_event_str, int error), >> + >> + TP_ARGS(dev, pm_ops, ops_time, pm_event_str, error), >> + >> + TP_STRUCT__entry( >> + __string(device, dev_name(dev)) >> + __string(driver, dev_driver_string(dev)) >> + __string(parent, dev->parent ? dev_name(dev->parent) : "none") >> + __string(pm_ops, pm_ops ? pm_ops : "none ") >> + __string(pm_event_str, pm_event_str) >> + __field(s64, ops_time) >> + __field(int, error) >> + ), >> + >> + TP_fast_assign( >> + __assign_str(device, dev_name(dev)); >> + __assign_str(driver, dev_driver_string(dev)); >> + __assign_str(parent, >> + dev->parent ? dev_name(dev->parent) : "none"); > > Have you tried using the temp variables? These macros expand to be > called multiple times. > > -- Steve
Steve, Tried with temp variables. Patch is on its way with temp variables. I generated .s with and without temp variables and didn't see any difference. Should I be seeing a difference, if so what am I missing? In any case, you have the patch v6 with temp variables. -- Shuah Shuah Khan, Linux Kernel Developer - Open Source Group Samsung Research America (Silicon Valley) [email protected] | (970) 672-0658 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
