On Mon, 2013-07-22 at 15:43 +0200, Oleg Nesterov wrote: > Hello. > > Only slightly tested so far. I'll try to test more and report > the results. > > Meanwhile it would be nice if you can take a look and review. > > > This series kills tracing_open_generic_tc/trace_cpu/etc. > > trace_array_get(inode->i_private) is mostly fine, we do not > dereference this pointer untill trace_array_get() succeeds. > But trace_array_get(tc->tr) is wrong by the same reason why > tracing_open_generic_file/etc are wrong, see 1/7. > > And not only trace_cpu is buggy, we can simplify the code if > we kill this member. >
Oleg, So far I like the patch set. I just want to get Al's OK before we do a hack with an inode structure item. Thanks! -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
