Hi Guennadi, Thanks for your efforts on this.
On Tue, Jul 23, 2013 at 7:49 PM, Guennadi Liakhovetski <[email protected]> wrote: > This configuration data will be re-used, when DMAC DT support is added to > r8a7740, DMAC platform data in setup-r8a7740.c will be removed. > > Signed-off-by: Guennadi Liakhovetski <[email protected]> > --- > > v4: make struct sh_dmae_pdata r8a7740_dma_pdata "const" > [snip] > --- /dev/null > +++ b/drivers/dma/sh/shdma-r8a7740.c > @@ -0,0 +1,95 @@ > +#include <linux/sh_dma.h> > + > +#include <mach/dma-register.h> > +#include <mach/r8a7740.h> Including stuff from <mach/..> isn't really compatible with MULTIPLATFORM, so please don't write new code like this. Actually we don't want any code under drivers/ to include stuff from the mach directory. I suggest that you arrange your code in a way so the C version of DMAC support has tables with slave ids as usual under arch/arm/mach-shmobile/, but the DT bits that operate independently of C stay in drivers/... Over time we will get rid of the C version, and until that happens the DT and C version can coexist in parallel. Cheers, / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
