On Thu, 2013-07-25 at 01:27 +0000, Cong Wang wrote: > On Tue, 23 Jul 2013 at 17:58 GMT, Joe Perches <[email protected]> wrote:
You dropped the author from the cc list. Always reply to the author. > > Function prototypes don't need to be declared > > extern in .h files. It's assumed by the compiler > > and is as unnecessary as using auto is when > > declaring automatic/local variables in a block. > > > Since we all know this, why bother it? If everyone knew this, new ones wouldn't be added. But a lot are. Removing extern makes prototypes shorter and more readable. More prototypes fit in a single line More arguments fit on a multi-line prototypes. > Having "extern" doesn't harm > readability, instead it probably helps. Sure, just like auto does. Why isn't that used? > > I believe it makes grepping for extern useful as > > all the matches are actual variables and structs. > You need a semantic tool. No, not really. I'm fairly comfortable with spatch. spatch takes a long time to run for a lot of things. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
