On Thu, Jul 25, 2013 at 04:29:13PM -0400, KOSAKI Motohiro wrote:
> (7/24/13 4:32 PM), Johannes Weiner wrote:
> >@@ -1189,9 +1174,17 @@ good_area:
> > */
> > fault = handle_mm_fault(mm, vma, address, flags);
> >
> >- if (unlikely(fault & (VM_FAULT_RETRY|VM_FAULT_ERROR))) {
> >- if (mm_fault_error(regs, error_code, address, fault))
> >- return;
> >+ /*
> >+ * If we need to retry but a fatal signal is pending, handle the
> >+ * signal first. We do not need to release the mmap_sem because it
> >+ * would already be released in __lock_page_or_retry in mm/filemap.c.
> >+ */
> >+ if ((fault & VM_FAULT_RETRY) && fatal_signal_pending(current))
> >+ return;
> >+
> >+ if (unlikely(fault & VM_FAULT_ERROR)) {
> >+ mm_fault_error(regs, error_code, address, fault);
> >+ return;
> > }
>
> When I made the patch you removed code, Ingo suggested we need put all rare
> case code
> into if(unlikely()) block. Yes, this is purely micro optimization. But it is
> not costly
> to maintain.
Fair enough, thanks for the heads up!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
