On Mon, 2013-07-29 at 12:52 -0700, Sarah Sharp wrote: > Hi Andy and Joe,
Hi Sarah. > Checkpatch is complaining when code adds new trace events macros: > > sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/.to-apply > Applying: xhci: add traces for debug messages in xhci_address_device() > ERROR: Macros with complex values should be enclosed in parenthesis > #86: FILE: drivers/usb/host/xhci-trace.h:15: > +#define TRACE_SYSTEM xhci-hcd <shrug> I think these are suboptimal as the files should use underscores rather than dashes. checkpatch sees this as a subtraction which really should have parentheses. > ERROR: Macros with complex values should be enclosed in parenthesis > #115: FILE: drivers/usb/host/xhci-trace.h:44: > +#define TRACE_INCLUDE_PATH . > > ERROR: Macros with complex values should be enclosed in parenthesis > #118: FILE: drivers/usb/host/xhci-trace.h:47: > +#define TRACE_INCLUDE_FILE xhci-trace Don't expect to checkpatch to be perfect. It's not. It's a stupid little tool good for some things and good for highlighting areas that might need another look. Use your judgment about everything it spews. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
