(2013/07/29 23:21), Oleg Nesterov wrote: > On 07/29, Masami Hiramatsu wrote: >> >> (2013/07/27 2:25), Oleg Nesterov wrote: >>> Change remove_event_file_dir() to clear ->i_private for every >>> file we are going to remove. >> >> Oleg, I think this should be done first. >> >> AFAICS, your former patches depend strongly on this change. >> Without this, they don't work as you expected, and it may >> prevent git-bisect. > > Why? > > v2 specially does this in the last change for bisecting/etc. > > 1-4 change f_op->read/write to check i_private != NULL but until > this final patch i_private == NULL is not possible.
Ah, OK. So 1-4 changes still remain refcount code, then it is safe, just i_private != NULL are added. I misread. >> I see, including this patch also breaks current ftrace. > > Could you clarify? Yes, let me add reviewed-by tags ;) Thank you, -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu...@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
