Due to the way active_load_balance_cpu gets called and the parameters passed to it, the active_load_balance_cpu_stop call gets split into multiple lines. Instead move it into a separate helper function.
this is a cleanup change. No functional changes. Signed-off-by: Srikar Dronamraju <sri...@linux.vnet.ibm.com> --- kernel/sched/fair.c | 13 ++++++++----- 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 8fcbf96..debb75a 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -5103,6 +5103,12 @@ static int need_active_balance(struct lb_env *env) static int active_load_balance_cpu_stop(void *data); +static void active_load_balance(struct rq *rq) +{ + stop_one_cpu_nowait(cpu_of(rq), active_load_balance_cpu_stop, rq, + &rq->active_balance_work); +} + /* * Check this_cpu to ensure it is balanced within domain. Attempt to move * tasks if there is an imbalance. @@ -5290,11 +5296,8 @@ static int load_balance(int this_cpu, struct rq *this_rq, } raw_spin_unlock_irqrestore(&busiest->lock, flags); - if (active_balance) { - stop_one_cpu_nowait(cpu_of(busiest), - active_load_balance_cpu_stop, busiest, - &busiest->active_balance_work); - } + if (active_balance) + active_load_balance(busiest); /* * We've kicked active balancing, reset the failure -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/