From: Greg KH <gre...@linuxfoundation.org>
Date: Tue, 30 Jul 2013 07:00:59 -0700
> This call is so slow, you can afford to make a call to kmalloc for the
> data, as it sure just did for other structures it needed :)
I told him to implement things this way, to avoid calling kmalloc every
single register access.
Using kmalloc all the time makes the access fragile, since a badly timed
call during high memory pressure can fail.
I'd rather the potential failure happen at one time, probe time.
In any event, Ming Lei has suggested using usbnet_{read,write}_cmd()
instead, which sounds like a good solution to this problem.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
