On Fri, 02 Aug 2013, Jingoo Han wrote: > Add CONFIG_PM_SLEEP to suspend/resume functions to fix the build > warnings when CONFIG_PM_SLEEP is not selected. This is because > sleep PM callbacks defined by SET_SYSTEM_SLEEP_PM_OPS are only used > when the CONFIG_PM_SLEEP is enabled. > > drivers/mfd/ab8500-gpadc.c:891:12: warning: 'ab8500_gpadc_suspend' defined > but not used [-Wunused-function] > drivers/mfd/ab8500-gpadc.c:903:12: warning: 'ab8500_gpadc_resume' defined but > not used [-Wunused-function] > > Signed-off-by: Jingoo Han <[email protected]> > --- > drivers/mfd/ab8500-gpadc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c > index 77c616f..36000f9 100644 > --- a/drivers/mfd/ab8500-gpadc.c > +++ b/drivers/mfd/ab8500-gpadc.c > @@ -888,6 +888,7 @@ static int ab8500_gpadc_runtime_resume(struct device *dev) > } > #endif > > +#ifdef CONFIG_PM_SLEEP > static int ab8500_gpadc_suspend(struct device *dev) > { > struct ab8500_gpadc *gpadc = dev_get_drvdata(dev); > @@ -915,6 +916,7 @@ static int ab8500_gpadc_resume(struct device *dev) > mutex_unlock(&gpadc->ab8500_gpadc_lock); > return ret; > } > +#endif > > static int ab8500_gpadc_probe(struct platform_device *pdev) > {
Looks sensible. I wonder why we haven't caught these before. I guess we always enable PM_SLEEP. Applied until Linus tells me otherwise. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
